Prepare for a backend job by mastering computer science fundamentals

6 Things to Avoid When Contributing to Open-Source Projects

By Lane Wagner on Oct 21, 2020

With #HacktoberFest being a thing, there has been an influx of devs desperately trying to contribute to their favorite Open-Source projects. Unfortunately, many of these pull requests have been a waste of time, with the maintainers ultimately unable to use the contributions. Maintainers don’t want to waste their time reviewing bad PRs, and contributors don’t want to waste their time writing code that will never make it into production.

Let’s take a look at some common pitfalls that developers fall prey to when working on an open-source project.

1. Pull Requests Should Handle ONE Thing

Don’t open a PR like this:

Your PR should do one thing. Large diffs increase the cognitive load of the reviewer and make it easier to get your code into the main branch. If you have beef with multiple issues in a project then open multiple PRs.

A simple path to your career in backend development

The pace of Boot.dev's JavaScript, Python and Go courses has been perfect for me. The diverse community in Discord is a blast, and other members are quick to help out with detailed answers and explanations.

- Daniel Gerep from Cassia, Brasil

2. Don’t Break Consistency

This one happens the most often to me in my own projects. Well-intentioned developers open pull requests with any of the following annoyances:

When you contribute to an existing project, use the existing styling. No one gives two hoots about your preference on the “tabs vs spaces” debate in the context of this pull request.

If you think styling needs to change, see points #1 and #3.

3. Don’t Start Work Without Approval

If you hop into a Github repo and find something you don’t like, don’t immediately open a pull request. Follow these steps instead:

This will help mitigate the creation of pointless PRs that will never be accepted on the basis of a flawed premise.

Get backend development jobs by learning CS

I was a field service engineer and I wanted to become a backend developer, but work and family limited my options. Since completing the backend-focused computer science track on Boot.dev, I now have a job offer in hand and I'm starting my career as a software developer!

- Özgür Yildirim from Germany

4. Don’t Re-Open Known Problems/Solutions

Some codebases have thousands of open issues, take the Go language project or the nocode repository as an example. No one wants to read your duplicate issue or review your duplicate pull request. Make sure there isn’t an existing open or closed issue for what you are trying to address.

5. Squash Those Commits

Not every project will require (or care) about commit squashing. That said, there are no projects that require not squashing commits. To be on the safe side just give ‘em a squash.

6. Be Meaningful

Rewording documentation and other frivolous changes make you look like these assholes. This particularly atrocious example is not only scoped to pointless documentation changes but actually makes the documentation worse.

Become a backend engineer by building real projects

Related Reading